Catch exceptions in tunnel host async void method #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasongin
force-pushed
the
dev/jasongin/forwardex
branch
from
129498b
to
bfd51f2
Compare
IlyaBiryukov
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port-forwarding can throw
ObjectDisposedExceptionif the SSH session is closed at just the wrong time. That was causing some crashes when that exception occurred within theasync void OnSshClientAuthenticatedevent handler method in the tunnel SDK.Also updating to the latest SSH package version to pick up the fix for concurrent session requests.